moodlite

moodlite => moodlite Software => Topic started by: spigot on April 28, 2019, 05:46:19 PM

Title: moodlite software [3.0] Release
Post by: spigot on April 28, 2019, 05:46:19 PM
moodlite software [3.0] Release

https://moodlite.co.uk/index.php?action=downloads;sa=view;down=7 (https://moodlite.co.uk/index.php?action=downloads;sa=view;down=7)
Title: Re: moodlite software [3.0] Release
Post by: Dennisch on April 28, 2019, 08:32:30 PM
It will be a OTA update? :)
Title: Re: moodlite software [3.0] Release
Post by: tadrow on April 30, 2019, 02:25:32 AM
In the onEvent function, I'm sort of curious about the line data[len] = 0;  It seems like you're writing to a buffer that the callback function doesn't own, and also specifically writing past the end of the buffer.  That code was eventually causing a crash every time I tried to change a value.  I modified the code to use ByteString which looks like it was made for this purpose and everything worked fine.  I'm not sure why more people aren't seeing this crash, but to my eye, that code is definitely dangerous.
Title: Re: moodlite software [3.0] Release
Post by: kino90 on May 05, 2019, 01:54:30 AM
I will update mine soon.. is this fixed on github?
Title: Re: moodlite software [3.0] Release
Post by: mar_robHD on May 05, 2019, 12:29:51 PM
In the onEvent function, I'm sort of curious about the line data[len] = 0;  It seems like you're writing to a buffer that the callback function doesn't own, and also specifically writing past the end of the buffer.  That code was eventually causing a crash every time I tried to change a value.  I modified the code to use ByteString which looks like it was made for this purpose and everything worked fine.  I'm not sure why more people aren't seeing this crash, but to my eye, that code is definitely dangerous.
What is your code now? Can you post it here?